From f5f1c8ac424dfae7179be01d0f2e07a033c8185c Mon Sep 17 00:00:00 2001
From: Wind-Explorer <windexplorer@outlook.com>
Date: Sun, 29 Mar 2026 19:29:34 +0800
Subject: [PATCH] fix(ws): make notification publish fail open with local
 fallback

---
 src/ws/state/ws-notification.service.ts | 52 +++++++++++++++++++------
 1 file changed, 40 insertions(+), 12 deletions(-)

diff --git a/src/ws/state/ws-notification.service.ts b/src/ws/state/ws-notification.service.ts
index 3533de8..34a3ad4 100644
--- a/src/ws/state/ws-notification.service.ts
+++ b/src/ws/state/ws-notification.service.ts
@@ -48,13 +48,27 @@ export class WsNotificationService {
     action: 'add' | 'delete',
   ) {
     if (this.redisClient) {
-      await this.redisClient.publish(
-        REDIS_CHANNEL.FRIEND_CACHE_UPDATE,
-        JSON.stringify({ userId, friendId, action }),
-      );
-    } else {
-      // Fallback: update locally
+      try {
+        await this.redisClient.publish(
+          REDIS_CHANNEL.FRIEND_CACHE_UPDATE,
+          JSON.stringify({ userId, friendId, action }),
+        );
+        return;
+      } catch (error) {
+        this.logger.warn(
+          'Redis publish failed for friend cache update; applying local cache update only',
+          error as Error,
+        );
+      }
+    }
+
+    try {
       await this.updateFriendsCacheLocal(userId, friendId, action);
+    } catch (error) {
+      this.logger.error(
+        'Failed to apply local friend cache update',
+        error as Error,
+      );
     }
   }
 
@@ -89,13 +103,27 @@ export class WsNotificationService {
 
   async publishActiveDollUpdate(userId: string, dollId: string | null) {
     if (this.redisClient) {
-      await this.redisClient.publish(
-        REDIS_CHANNEL.ACTIVE_DOLL_UPDATE,
-        JSON.stringify({ userId, dollId }),
-      );
-    } else {
-      // Fallback: update locally
+      try {
+        await this.redisClient.publish(
+          REDIS_CHANNEL.ACTIVE_DOLL_UPDATE,
+          JSON.stringify({ userId, dollId }),
+        );
+        return;
+      } catch (error) {
+        this.logger.warn(
+          'Redis publish failed for active doll update; applying local cache update only',
+          error as Error,
+        );
+      }
+    }
+
+    try {
       await this.updateActiveDollCache(userId, dollId);
+    } catch (error) {
+      this.logger.error(
+        'Failed to apply local active doll cache update',
+        error as Error,
+      );
     }
   }
 }